Ks 2021 12 token voting permissions

[Rineee]

I did some more research and decided to not use rules for the token voting api permissions as rules are dependent on users and arent really useful here.
I instead introduced a new Permission class, called TokenVotePermission that checks manually the relevant requirements on the token for create and destroy actions.
Also, I added a check in TokenVoteMixin to make sure that the token is valid before anything else is checked.

[Rineee]

@fuzzylogic2000 Now I remember why I also wanted to add the phase to the serializer, we also use the isVotingPhase for not showing the ratings here:

a4-meinberlin/meinberlin/apps/budgeting/assets/BudgetingProposalListItem.jsx

Line 23 in d69a4dd

{!isVotingPhase && (

Not sure how to deal with it if not with serializer info, do you have an idea?

[fuzzylogic2000]

@fuzzylogic2000 Now I remember why I also wanted to add the phase to the serializer, we also use the isVotingPhase for not showing the ratings here:

a4-meinberlin/meinberlin/apps/budgeting/assets/BudgetingProposalListItem.jsx

Line 23 in d69a4dd

{!isVotingPhase && (

Not sure how to deal with it if not with serializer info, do you have an idea?

So, the decision was to just keep it in the template tag for now, right?

[Rineee]

@fuzzylogic2000 Now I remember why I also wanted to add the phase to the serializer, we also use the isVotingPhase for not showing the ratings here:

a4-meinberlin/meinberlin/apps/budgeting/assets/BudgetingProposalListItem.jsx

Line 23 in d69a4dd

{!isVotingPhase && (

Not sure how to deal with it if not with serializer info, do you have an idea?

So, the decision was to just keep it in the template tag for now, right?

Yes! Should I write an issue to think about moving it to the api?

[github-actions]

Coverage report

Total coverage

Status	Category	Percentage	Covered / Total
🔴	Statements	11.75%	157/1336
🔴	Branches	9.82%	75/764
🔴	Functions	11.94%	53/444
🔴	Lines	18.03%	711/3943

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status	Filename	Statements	Branches	Functions	Lines
🔴	meinberlin/apps/budgeting/assets/VoteButton.jsx	0% (-33.33% 🔻)	0% (-25% 🔻)	0% (-16.67% 🔻)	0% (-69.7% 🔻)
🟢	meinberlin/apps/budgeting/assets/BudgetingProposalListItem.jsx	100%	50% (-30% 🔻)	100%	100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 1267280

[philli-m]

install and passing tests but vote button functioonality no longer working, is this expected?

[Rineee]

install and passing tests but vote button functioonality no longer working, is this expected?

@phillimorland No, that should work still! What does it say in the network tab?

[philli-m]

@Rineee ignore me, I forgot I had to re-enter my token :p however I will add that we must disable hover styling on the disabled vote button