Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 2021 12 styling issues jan milestone #4112

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

philli-m
Copy link
Contributor

No description provided.

… sm screens fixes partially #4047

assets/form: rm token input bottom margin on large screens
@philli-m philli-m force-pushed the pm-2021-12-styling-issues-jan-milestone branch from 630abfe to 92aaf34 Compare December 23, 2021 10:04
@github-actions
Copy link

github-actions bot commented Dec 23, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 11.94% 159/1332
🔴 Branches 9.76% 74/758
🔴 Functions 11.96% 53/443
🔴 Lines 18.33% 720/3929

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 meinberlin/apps/budgeting/assets/FilterBarDropdown.jsx 84.21% 90% (-1.67% 🔻) 77.78% 100%
🟢 meinberlin/apps/budgeting/assets/FilterBar.jsx 100% 85.71% (-5.19% 🔻) 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 62ae536

@philli-m philli-m force-pushed the pm-2021-12-styling-issues-jan-milestone branch from 92aaf34 to 62ae536 Compare December 23, 2021 10:26
@@ -37,43 +37,32 @@ export const FilterBar = props => {
}

const prepareFilter = (filter, filterType) => {
Copy link
Contributor Author

@philli-m philli-m Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this function is still needed? attempts to rm errored though so thought would leave it for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a question to @khamui ?

@philli-m philli-m changed the title WIP Pm 2021 12 styling issues jan milestone Pm 2021 12 styling issues jan milestone Dec 23, 2021
Copy link
Contributor

@khamui khamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me!

Copy link
Contributor

@Rineee Rineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, cool!

@Rineee Rineee merged commit 98a73d8 into main Dec 23, 2021
@Rineee Rineee deleted the pm-2021-12-styling-issues-jan-milestone branch December 23, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants