apps/livequestions apps/plans: fixed missing translations by moving translation strings into variables at top of files in all affected jsx files #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 1e15476 |
sabinammm
changed the title
fuzzylogic2000
approved these changes
Jan 13, 2022
| @@ -2,6 +2,14 @@ | |||
| const React = require('react') | |||
| const Moment = require('moment') | |||
|
|
|||
| const remainingStr = django.gettext('remaining') | |||
There was a problem hiding this comment.
nice, that you also moved these to the front!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issues #4150 and #4149 as caused by PR #4126
Leaving this in WIP until question is resolved, i.e. if there is another PR besides #4126 that deleted translations that are actually still needed.