Move translations in JSX-Files to variables #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabinammm
changed the title
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from e8053c3 |
sabinammm
changed the title
fuzzylogic2000
approved these changes
Feb 1, 2022
locale/de_DE/LC_MESSAGES/djangojs.po
Outdated
Comment on lines
1055
to
1056
| msgid " in the area of " | ||
| msgstr "und dem Bereich" |
There was a problem hiding this comment.
Why do we need the spaces in the original string, but not in the translation? That's something that could be fixed with this PR! (If we don't need the spaces, also remove them in the original string.)
sabinammm
force-pushed
the
sm-2022-01-move-translations-to-variables
branch
from
2d13a50 to
e8053c3
Compare
fuzzylogic2000
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.