Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/plans & apps/plans/templates: default text for participation explanation #4233

Conversation

sabinammm
Copy link
Contributor

Commit 1:
apps/plans: remove default text from plan-participation-explanation
Fixes #4222

Commit 2:
apps/plans/templates: plan detail shows no participation explanation box when explanation is default text in old plans
Fixes #4225

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.1% 162/1781
🔴 Branches 6.95% 67/964
🔴 Functions 9.06% 50/552
🔴 Lines 13.16% 677/5143

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 93b535b

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one change to keep the template code as readable as possible.

@@ -145,8 +145,8 @@ <h3 class="item-detail-2__info-box-headline">{% trans 'Level of participation' %
{% else %}
{{ object.participation_explanation }}
{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole block needs to be indented one indent less. I.e. has to be shifted one indent left.

…box when explanation is default text in old plans

Fixes #4225
@sabinammm sabinammm force-pushed the sm-2022-03-issue-default-text-plan-participation-explanation branch from 7f7ee1a to 93b535b Compare March 4, 2022 10:10
@sabinammm sabinammm requested a review from fuzzylogic2000 March 4, 2022 10:20
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fuzzylogic2000 fuzzylogic2000 merged commit 51f1661 into main Mar 9, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the sm-2022-03-issue-default-text-plan-participation-explanation branch March 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants