Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/newsletter: check that not choosing project does give an error … #4321

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

fuzzylogic2000
Copy link
Contributor

…instead of 500

I wanted to properly check that

self.add_error('project', _('Select a Project'))
gives a FieldError when there is no project added. But when posting, the error is just added to the error list in the content. So, this checks that we stay on the form page instead of getting a redirect like when successfull form submit. Should still be fine to test that it does not yet work in a+ liqd/adhocracy-plus#1737

@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2022-04-newsletter-test branch from 9c1bfe5 to 00212b1 Compare April 22, 2022 09:41
@github-actions
Copy link

github-actions bot commented Apr 22, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.11% 162/1779
🔴 Branches 6.95% 67/964
🔴 Functions 9.01% 50/555
🔴 Lines 13.15% 677/5150

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 76fdcd5

@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2022-04-newsletter-test branch from 00212b1 to 76fdcd5 Compare April 22, 2022 09:53
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool!

@goapunk goapunk merged commit 03270e2 into main Apr 22, 2022
@goapunk goapunk deleted the kl-2022-04-newsletter-test branch April 22, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants