Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace node-sass with sass #4458

Merged
merged 1 commit into from
Sep 8, 2022
Merged

replace node-sass with sass #4458

merged 1 commit into from
Sep 8, 2022

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Sep 8, 2022

No description provided.

@goapunk goapunk requested a review from philli-m September 8, 2022 10:28
@goapunk
Copy link
Contributor Author

goapunk commented Sep 8, 2022

should also help with ci speed I think

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.14% 165/1805
🔴 Branches 6.45% 67/1039
🔴 Functions 8.98% 51/568
🔴 Lines 13.12% 701/5342

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ec60810

philli-m
philli-m approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@philli-m philli-m merged commit a35ec3e into main Sep 8, 2022
@philli-m philli-m deleted the jd-2022-09-replace-node-sass branch September 8, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @philli-m