Ks 2022 09 proposals random sorting #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamui
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
working fine!
the preserved variable is hard to read for me, but its my inexperience :) Leaving for @fuzzylogic2000 to doublecheck!
| if ordering: | ||
| if ordering == ['-daily_random']: | ||
| pks = list(queryset.values_list('pk', flat=True)) | ||
| random.seed(str(date.today())) |
Rineee
changed the title
Rineee
force-pushed
the
ks-2022-09-proposals-random-sorting
branch
from
b477814 to
6d078b8
Compare
Rineee
changed the title
fuzzylogic2000
approved these changes
Sep 16, 2022
fuzzylogic2000
force-pushed
the
ks-2022-09-proposals-random-sorting
branch
from
6d078b8 to
b13d64c
Compare
| @@ -85,12 +85,13 @@ def list(self, request, *args, **kwargs): | |||
| ordering_choices = [('-created', _('Most recent')), ] | |||
| if self.module.has_feature('rate', Proposal): | |||
| ordering_choices += ('-positive_rating_count', _('Most popular')), | |||
| ordering_choices += ('-comment_count', _('Most commented')), | |||
| ordering_choices += ('-comment_count', _('Most commented')), \ | |||
| ('-daily_random', _('Random')), | |||
There was a problem hiding this comment.
Why the -? It probably doesn't matter if we use the random ascending or descending.
fuzzylogic2000
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The random stuff is copied from here. Im a bit unhappy with doubling everything, but did not know how else to do it in a good way?
ToDo: