Kl 2022 09 dashboard token perms #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
force-pushed
the
kl-2022-09-dashboard-token-perms
branch
from
e10cc74 to
a76cdbf
Compare
fuzzylogic2000
commented
Sep 20, 2022
meinberlin/templates/a4dashboard/includes/nav_modules_item.html
Outdated
Show resolved
Hide resolved
fuzzylogic2000
force-pushed
the
kl-2022-09-dashboard-token-perms
branch
from
a76cdbf to
3d9d435
Compare
Rineee
reviewed
Sep 20, 2022
Rineee
approved these changes
Sep 20, 2022
fuzzylogic2000
force-pushed
the
kl-2022-09-dashboard-token-perms
branch
from
3d9d435 to
92070ec
Compare
fuzzylogic2000
force-pushed
the
kl-2022-09-dashboard-token-perms
branch
from
92070ec to
ad11e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unhappy with how I did it and with the naming, but I couldn't think of a better (and not also overly complex) way. It should work better with the permissions from the view somehow, but as we don't have the user in the dashboard components, and I didn't want to add that complexity, I did it like that. 🤷♀️ And I thought, if we ever need more and other perms in the dashboard, we can still improve from here.
Depending on liqd/adhocracy4#1216
Right, and the two first commits are from #4477
So, these both need to be merged first and this cleaned up then.