[#6422] pagination issues fixes

[khamui]

No description provided.

[goapunk]

nice fixes! just one small thing

[khamui]

just realize #4510 is just fixed for the react pagination, still the django pagination needs to be done, but not sure if this is quite a bit of rework (at least for me).

done both for react and django

[goapunk]

nice, looks good to me!

[philli-m]

few questions :)

[philli-m]

cool, just a few comments and I just noticed when checking it this time that we don't use BEM, maybe we can change pagination-item to pagination__item?

[philli-m]

you only need to add the padding change here so all the other styles can be deleted, also as we are trying to adopt mobile first format you can use a min-width query and swap the padding values around. For the padding values, as the smallest screen we ensure design works for is 360, I think the xaxis padding can be a touch bigger to help with button size a11y

[philli-m]

maybe 0.7 or 0.75 just from having a quick play in the browser but your call

[philli-m]

why do you want to add an additional breakpoint? also this is added as a min width value but you use it in a max width query, we don't really want to add additional break points as it add complexity, applying the same style up to a width of 512px is pretty standard, bootstraps first breakpoint is 576 so we aren't far off the norm.

[khamui]

oh yeah, messing up things here! will remove it and use xs instead

[fuzzylogic2000]

What is the status here? @khamui It is finished and can be reviewed again? Will you do that @phillimorland ? Or should I? (I am not sure I will notice everything you talked about.)

[philli-m]

@fuzzylogic2000 sorry didn't see the re-tag, will take a look now

[philli-m]

perfect! :)