Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updates] fixes from style lib removal #4516

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Sep 26, 2022

Mostly fixes #4515
fixes #4521

@philli-m philli-m changed the title Pm 2022 09 contrast color [updates] Pm 2022 09 contrast color Sep 26, 2022
@philli-m philli-m changed the title [updates] Pm 2022 09 contrast color WIP [updates] Pm 2022 09 contrast color Sep 26, 2022
@philli-m philli-m force-pushed the pm-2022-09-contrast-color branch 2 times, most recently from 045fea9 to 5ca90bc Compare September 27, 2022 15:15
@philli-m philli-m changed the title WIP [updates] Pm 2022 09 contrast color WIP [updates] fixes from style lib removal Sep 27, 2022
@philli-m philli-m changed the title WIP [updates] fixes from style lib removal [updates] fixes from style lib removal Sep 27, 2022
@fuzzylogic2000 fuzzylogic2000 self-assigned this Sep 28, 2022
Copy link
Contributor

@khamui khamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice! few comments :)

meinberlin/assets/scss/components/_timeline.scss Outdated Show resolved Hide resolved
meinberlin/assets/scss/_form.scss Outdated Show resolved Hide resolved
meinberlin/assets/scss/components/_button.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One tiny question, though.

@fuzzylogic2000 fuzzylogic2000 removed their assignment Sep 28, 2022
@philli-m philli-m force-pushed the pm-2022-09-contrast-color branch from 5ca90bc to c13a829 Compare September 28, 2022 15:04
@philli-m philli-m requested a review from khamui September 28, 2022 15:04
Copy link
Contributor

@khamui khamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! once you're fine with the wording, feel free to merge!

@philli-m philli-m force-pushed the pm-2022-09-contrast-color branch from c13a829 to a5dd698 Compare September 29, 2022 07:10
@philli-m philli-m merged commit aa0b7ed into main Sep 29, 2022
@philli-m philli-m deleted the pm-2022-09-contrast-color branch September 29, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Field for categories doesn't adapt style issues from removal of style lib
3 participants