control-bar/filter: fixing behavior & fix spacing (styling) #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
approved these changes
Oct 6, 2022
|
|
||
| export const ControlBarDropdown = props => { | ||
| const { filter: { label, choices, current, icons } } = props | ||
| const { filter } = props | ||
| const [currentChoiceName, setCurrentChoiceName] = useState(filter.current) | ||
|
|
||
| const onSelectFilter = filter => { |
There was a problem hiding this comment.
suggestion: rename filter to newFilter or selectedFilter so it doesn't clash with the newly introduced const { filter } above?
khamui
force-pushed
the
kt-2022-09-fix-filter-issue
branch
from
6a3a05b to
d227be4
Compare
khamui
changed the title
|
wip to fix jstests |
khamui
force-pushed
the
kt-2022-09-fix-filter-issue
branch
from
d227be4 to
394e34a
Compare
khamui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.