[#6519] label on tiles #4542
Merged
[#6519] label on tiles #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamui
force-pushed
the
kt-2022-10-label-on-tiles
branch
from
18c4a08 to
ce6c9bd
Compare
|
oh, wip again, fixing tests |
khamui
force-pushed
the
kt-2022-10-label-on-tiles
branch
from
ce6c9bd to
12f6a40
Compare
Comment on lines
25
to
31
| // Before passing this data to 'ListItemBadges' component | ||
| // it needs to be normalized as the data types are different | ||
| // category: null || object | ||
| // labels: [] || array | ||
| // budget: 0 || number | ||
| // pointLabel: '' || string | ||
| // modFeedback: [null, null] || array |
There was a problem hiding this comment.
Uh. This makes sense, but shouldn't we change the serializer to give better values? We will have to change this for TS anyway. And in a lot of places. Maybe here is a good place to start and find out how we would like to get data from the API that can be there or not? We have all the examples you can think of in one place. :p
There was a problem hiding this comment.
@fuzzylogic2000 that is true. I will look into how to send them same from the serializer
|
Oh, and I thought of another thing: is that the right order of the labels? Shouldn't the labels (Merkmale) be last as only these can have multiple labels and all the moderator's status thing should probably always be shown? |
…omponent to support eliding (x More) rework after review: normalize None-case for fields that are being used as badges. And some smaller fixes
khamui
force-pushed
the
kt-2022-10-label-on-tiles
branch
from
12f6a40 to
b1c4a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.