Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategorySelect: manually trigger select2() #4544

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Oct 5, 2022

fix the broken select in the live event

@goapunk goapunk changed the title CategorySelect: manually trigger select2() WIP: CategorySelect: manually trigger select2() Oct 5, 2022
@goapunk
Copy link
Contributor Author

goapunk commented Oct 5, 2022

@khamui @phillimorland @fuzzylogic2000 @Rineee I'm a bit unsure about this, we do want to get rid of jquery (and therefore select2) so we should probably replace this altogether and use something else. The problem is there is no vanilla js library afaik, so we'd either have to:

  1. build one ourselves
  2. use react-select for react components and something else for non-react selects (annoying because we need two libraries or write everything in react)
  3. use bootstrap with the browser inbuilt select (can't really customize this one, so not a real option)
  4. ??

@goapunk goapunk force-pushed the jd-2022-10-fix-select2-live branch from 0d76d20 to eafbdd0 Compare October 6, 2022 07:44
@philli-m
Copy link
Contributor

@goapunk I might have a css only solution for this but will test and let you know, our current solution is not a11y compliant anyway so we do have to change it

@philli-m philli-m force-pushed the jd-2022-10-fix-select2-live branch from eafbdd0 to a0c0edd Compare October 17, 2022 12:57
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the react-select but didn't get it working properly and it SR was reading it out oddley so have just added a fixme for now, maybe will be more inspired tomorrow

@philli-m philli-m changed the title WIP: CategorySelect: manually trigger select2() CategorySelect: manually trigger select2() Oct 17, 2022
@philli-m philli-m merged commit 18dd0ac into main Oct 17, 2022
@philli-m philli-m deleted the jd-2022-10-fix-select2-live branch October 17, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants