Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets/dropdown: update focus colour and update aria label, rm pointl… #4562

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

philli-m
Copy link
Contributor

…ess class

expandFilters
? 'btn btn--light active'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no styling for active class on btns

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillimorland hm, i was sure that worked? maybe because of bootstrap.

In these cases i am not sure what to do though, the design asks for a visual active state (grey background). Now there is no background color anymore right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khamui btn had active style after click until there was another action on the page (like filter click) then it returns to a non active state and style which was the same behaviour as when the class was added

@philli-m philli-m force-pushed the pm-2022-10-a11y-filter branch from b05b391 to 5f61520 Compare October 13, 2022 14:33
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@fuzzylogic2000 fuzzylogic2000 merged commit ab9701d into main Oct 14, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the pm-2022-10-a11y-filter branch October 14, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants