budgeting: add rule to view support also between phases and use rule … #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rineee
force-pushed
the
ks-2022-10-budgeting-show-support-in-map-pop-up
branch
from
6360809 to
d8490c6
Compare
Rineee
commented
Oct 25, 2022
| {% map_display_points object_list module.settings_instance.polygon %} | ||
| {% if module.blueprint_type == 'PB3' %} | ||
| {% has_or_would_have_perm 'meinberlin_budgeting.view_support' request.user module as may_view_support %} | ||
| {% map_display_points object_list module.settings_instance.polygon 'true' may_view_support|yesno:"false,true" %} |
There was a problem hiding this comment.
This is a bit hacky with the yesno template tag, but did not really find a better solution for negating a bool in template 🤷♀️
Rineee
changed the title
Rineee
changed the title
…for map pop up in map view
Rineee
force-pushed
the
ks-2022-10-budgeting-show-support-in-map-pop-up
branch
from
5239650 to
fe098ee
Compare
|
@fuzzylogic2000 I decided to do the detail and list view permissions in another PR, so this one could already be reviewed, it only handles the map pop up. I added a task for the missing test.. |
goapunk
reviewed
Oct 26, 2022
Rineee
force-pushed
the
ks-2022-10-budgeting-show-support-in-map-pop-up
branch
from
fe098ee to
739c1c4
Compare
fuzzylogic2000
approved these changes
Oct 26, 2022
| {% map_display_points object_list module.settings_instance.polygon %} | ||
| {% if module.blueprint_type == 'PB3' %} | ||
| {% has_or_would_have_perm 'meinberlin_budgeting.view_support' request.user module as may_view_support %} | ||
| {% map_display_points object_list module.settings_instance.polygon 'true' may_view_support|yesno:"false,true" %} |
fuzzylogic2000
deleted the
ks-2022-10-budgeting-show-support-in-map-pop-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for map pop up in map view
depends on liqd/adhocracy4#1251Did not yet apply the rule in list and detail views, but added separate tasks in story.