Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 2022 10 styling issues #4609

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Pm 2022 10 styling issues #4609

merged 4 commits into from
Oct 26, 2022

Conversation

philli-m
Copy link
Contributor

No description provided.

@khamui khamui self-assigned this Oct 25, 2022
Copy link
Contributor

@khamui khamui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool fixes!

Just one question about the button text color, it is now secondary, in the designs it is black(ish). Is that intended?

@khamui khamui removed their assignment Oct 25, 2022
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What's the status? Can we rebase and merge?

.btn.btn--light {
@extend .btn-light;

background-color: $body-bg;
font-weight: normal;
border-color: $border-color;
color: $secondary;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this in style guide in zeplin didn't know they were blue before but maybe got messed up with the library removal

@philli-m
Copy link
Contributor Author

@fuzzylogic2000 if you wouldn't mind that would be fab! :)

@fuzzylogic2000 fuzzylogic2000 force-pushed the pm-2022-10-styling-issues branch from c184cfc to 0964d21 Compare October 26, 2022 11:49
@fuzzylogic2000 fuzzylogic2000 merged commit 2354678 into main Oct 26, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the pm-2022-10-styling-issues branch October 26, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants