-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm 2022 10 styling issues #4609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool fixes!
Just one question about the button text color, it is now secondary, in the designs it is black(ish). Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! What's the status? Can we rebase and merge?
.btn.btn--light { | ||
@extend .btn-light; | ||
|
||
background-color: $body-bg; | ||
font-weight: normal; | ||
border-color: $border-color; | ||
color: $secondary; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this in style guide in zeplin didn't know they were blue before but maybe got messed up with the library removal
@fuzzylogic2000 if you wouldn't mind that would be fab! :) |
…ucture and add rating padding
…aviour on small screens
…d but add styling for when checkbox is and make checkable on enter fixes #4137
c184cfc
to
0964d21
Compare
No description provided.