Ks 2022 11 support phase tests #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
approved these changes
Nov 7, 2022
added 2 commits
November 8, 2022 16:08
… different project accesses and test rules view_support and support_proposal
Rineee
force-pushed
the
ks-2022-11-support-phase-tests
branch
from
9d45fcc to
85ed36b
Compare
Rineee
commented
Nov 8, 2022
| @@ -35,22 +37,33 @@ def phase_allows_support(user, item): | |||
| @rules.predicate | |||
| def is_allowed_support_item(user, item): | |||
| if item: | |||
| return rules_predicates.is_superuser(user) | \ | |||
| return is_allowed_moderate_project(user, item) | \ | |||
There was a problem hiding this comment.
So I think this was missing, right? Now moderators, initiators, group members should have more permissions...
|
@fuzzylogic2000 I changed the rules again (see comment) and the tests accordingly, do you want to check again? If its ok like this, then we could maybe already merge, so Caro can test? And I do the templatetag tests in another PR and maybe you could rebase and add the group member stuff (or I can also do it!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fuzzylogic2000 I changed the is_allowed_view_support predicate to also consider project access and live context. But I am not sure if the moderator/initiator permissions are all good there?