[issues] toggle filters btn behavior #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
force-pushed
the
pm-2022-11-toggle-filters
branch
from
018f951 to
1978b4e
Compare
|
My guess its' that it is the prevent default in the filter button click? https://github.com/liqd/adhocracy4/blob/main/adhocracy4/comments_async/static/comments_async/comment_box.jsx#L261 |
philli-m
force-pushed
the
pm-2022-11-toggle-filters
branch
from
1978b4e to
b81c69c
Compare
philli-m
force-pushed
the
pm-2022-11-toggle-filters
branch
from
b81c69c to
87f4474
Compare
philli-m
changed the title
|
I actually did some other fixing, the button focus is not that same as on the comments but I read that we shouldn't have btn randomly loose focus so will leave that, still think having a separate component is good though as will add to a4 next time we do stuff there |
fuzzylogic2000
approved these changes
Nov 23, 2022
philli-m
force-pushed
the
pm-2022-11-toggle-filters
branch
from
87f4474 to
bc54ac5
Compare
|
when fixing tests I realised that we shouldn't show the search string when we are ordering list so fixed that |
…4547, hide filters and found string when no ideas
…nd replaced span badges with div badges
philli-m
force-pushed
the
pm-2022-11-toggle-filters
branch
from
bc54ac5 to
5f07dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fuzzylogic2000 or @goapunk I am very confused with this, so the behavior we wish can be seen in the filter toggle for the comments, so I copied that code to make a component, planning to use it in a4 but wanted to test it first and even with exact classes it still shows being active after filters are opened, even though in comments it does not and I have wasted too much time on this by now so any ideas would be great!?