Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks 2022 11 moderation tasks filter #4696

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Nov 17, 2022

@fuzzylogic2000 I already pushed this in case you need to go on with it..

The completed tasks can be added in the proposals admin. Although one can choose from any moderation task (not only the ones for the module), same for labels and categories, we should probably add a custom admin there.

I did not handle yet that only mod/initiators can view the filter.

@fuzzylogic2000
Copy link
Contributor

@fuzzylogic2000 I already pushed this in case you need to go on with it..

The completed tasks can be added in the proposals admin. Although one can choose from any moderation task (not only the ones for the module), same for labels and categories, we should probably add a custom admin there.

I did not handle yet that only mod/initiators can view the filter.

Yes, thank you! I will rebase on this branch. :)

@Rineee Rineee force-pushed the ks-2022-11-moderation-tasks-filter branch from 8f6b47c to 0dbfb51 Compare November 17, 2022 16:21
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supercool!
Just one tiny thing: Can we move the task filter to the end of the filters? Or was it in the design like that?

@Rineee Rineee force-pushed the ks-2022-11-moderation-tasks-filter branch from f083397 to 5f88327 Compare November 18, 2022 10:50
@Rineee
Copy link
Contributor Author

Rineee commented Nov 18, 2022

Supercool! Just one tiny thing: Can we move the task filter to the end of the filters? Or was it in the design like that?

No, its at the end in the design! In my head it was somehow connected to categories and labels, but thats a total dev perspective 😅 Changed it now!

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@fuzzylogic2000 fuzzylogic2000 merged commit 8e2a21d into main Nov 18, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2022-11-moderation-tasks-filter branch November 18, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants