-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps/budgeting: add anchor link and use in list #4782
Conversation
7db9708
to
3efe9df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the page anchor should work looking at the code but it's not and I don't know why? tested on ff and chrome
also we can add scroll-behavior: smooth;
to html to ensure it's not stuttery
@phillimorland It did work in Chromium. Will try again and add the smooth-thingy though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khamui Nice! For me it only works when there are multiple proposals in the list?
Would be cool, if you could make one commit of the two.
And maybe @phillimorland can also review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep looks good, it works but the scroll to view almost scrolls too far so the top of the content is already going off screen, maybe we add a ref div about the list item?
484e8dc
to
80989eb
Compare
@phillimorland about the offset (top edge) we decided to go with a small offset for now. In case there needs to be a positioning in the center, this would be a story for later with a design. |
80989eb
to
4cd6536
Compare
Alright! Talked to @phillimorland and wil merge! |
No description provided.