do not explicitly install py requirements only used in a4 #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
force-pushed
the
kl-2022-12-do-not-explicitly-install
branch
from
afa2fd5 to
b2f247a
Compare
fuzzylogic2000
force-pushed
the
kl-2022-12-do-not-explicitly-install
branch
from
b2f247a to
caa4b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depending on liqd/adhocracy4#1303
with that, we can delete the packages only usede in a4 from the requirements. I am not entirely sure that's how it should be done? It says while installing:
Using legacy 'setup.py install' for adhocracy4, since package 'wheel' is not installed.The second commit re,oved the setup.py from mB. We used to install mB in a+, but as we don't do that anymore, I think we don't need the setup.py anymore?