[6669] apps/contrib/item-detail: restyle moderator feedback, move status dis… #4818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
changed the title
fuzzylogic2000
force-pushed
the
kl-2023-01-moderator-feedback
branch
from
88581ea to
5595e49
Compare
khamui
force-pushed
the
kl-2023-01-moderator-feedback
branch
from
222d688 to
d9dbac8
Compare
khamui
changed the title
|
@fuzzylogic2000 there is one task I am not following. So I kept the wording for the headlines for now.
|
@khamui I think, we can leave that out for now. I will add a task! |
fuzzylogic2000
commented
Jan 11, 2023
|
@khamui I guess with this not being your branch, you didn't see the answer. :) |
khamui
force-pushed
the
kl-2023-01-moderator-feedback
branch
from
d9dbac8 to
eabb5cf
Compare
…ename moderator-info scss class to more general detail-info
fuzzylogic2000
force-pushed
the
kl-2023-01-moderator-feedback
branch
from
eabb5cf to
98a1607
Compare
|
@khamui Because of all the changing back and forth, I added everything in one commit. I think, it is fine like that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…play away from badges
This updates the labels, so that they are still all in the list, but the feedback one not in the detail view. It does also do the permissions and displays the box as we decided (only if there's content and the upper bit always to moderators). A proper styling is still missing, though:
think about the headline and its a11y for the actual feedback (we didn't want it twice, so what we call it in the form and so on is the headline to the new box and the organisation name and date are in the place of the headline now)I will keep this WIP and hope @khamui or @phillimorland can take over?