Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6951]scss/modal: styling modal to match design (depending on a4) #4871

Merged
merged 2 commits into from
Feb 6, 2023
Merged

[#6951]scss/modal: styling modal to match design (depending on a4) #4871

merged 2 commits into from
Feb 6, 2023

Conversation

khamui
Copy link
Contributor

@khamui khamui commented Jan 24, 2023 •
edited
Loading

fixes #4232

@khamui khamui added the Dev: A4 depending PR or issue dependent on A4 label Jan 24, 2023
@khamui khamui changed the title [#6951]scss/modal: styling modal to match design (depending on a4) WIP [#6951]scss/modal: styling modal to match design (depending on a4) Jan 24, 2023
@khamui khamui changed the title WIP [#6951]scss/modal: styling modal to match design (depending on a4) [#6951]scss/modal: styling modal to match design (depending on a4) Jan 25, 2023
@khamui khamui changed the title [#6951]scss/modal: styling modal to match design (depending on a4) WIP [#6951]scss/modal: styling modal to match design (depending on a4) Jan 26, 2023
@khamui khamui changed the title WIP [#6951]scss/modal: styling modal to match design (depending on a4) [#6951]scss/modal: styling modal to match design (depending on a4) Jan 26, 2023
philli-m
philli-m suggested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So also a slightly odd thing, the modal for end session I think the variables may not have been updated as modal title is inside the body whereas with the others here it is within the header? also it is not centering?!

meinberlin/assets/scss/components/_modal.scss Outdated Show resolved Hide resolved
meinberlin/apps/plans/templates/meinberlin_plans/plan_update_form.html Show resolved Hide resolved
meinberlin/apps/plans/templates/meinberlin_plans/plan_update_form.html Show resolved Hide resolved
meinberlin/templates/a4dashboard/includes/nav_modules_item.html Show resolved Hide resolved
@khamui khamui force-pushed the kt-2023-01-modal-refactor branch from 847fd76 to bda6253 Compare February 1, 2023 15:34
@khamui khamui force-pushed the kt-2023-01-modal-refactor branch 3 times, most recently from 7cb4651 to 43475c5 Compare February 2, 2023 13:04
@khamui khamui requested a review from philli-m February 2, 2023 16:00
@philli-m philli-m force-pushed the kt-2023-01-modal-refactor branch from 43475c5 to be1da37 Compare February 3, 2023 11:05
philli-m
philli-m approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! have updated a4, will wait for ci but good to merge

@khamui khamui merged commit 325b6a3 into main Feb 6, 2023
@khamui khamui deleted the kt-2023-01-modal-refactor branch February 6, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philli-m philli-m philli-m approved these changes

@goapunk goapunk Awaiting requested review from goapunk

@fuzzylogic2000 fuzzylogic2000 Awaiting requested review from fuzzylogic2000

@Rineee Rineee Awaiting requested review from Rineee

Assignees
No one assigned
Labels
Dev: A4 depending PR or issue dependent on A4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consistent design of Modals over whole site
2 participants
@khamui @philli-m