-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6951] apps/budgeting: end session on button click #4878
Conversation
link comes with modal in this commit: |
@@ -16,6 +16,7 @@ export const BudgetingProposalList = (props) => { | |||
return django.interpolate(countText, [votes]) | |||
} | |||
const noResults = django.gettext('Nothing to show') | |||
const endSessionString = django.gettext('Are you ready? End session') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be are you finished right? are you ready doesn't really make sense in the context
There is no way to load the django token form other then a page reload which I have added. @goapunk or @Rineee i'm not sure on the get or post stuff if either of you have an opinion i can implement while trying to fix the firefox caching? This will be looked at in filter issue |
I'm fine with |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
93bbdd9
to
5bd8987
Compare
…o ensure django token form reloaded, not possible in react
ae80fc3
to
cbce40f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, the wording can be changed with the modal? or should we wait till the modal PR is merged?
Oh, this feels very unrefined and clunky. For the logout, we do a post, so maybe we should also do a post instead of the get here after all? And maybe some different permissions? (@Rineee @goapunk)
And in this version the button works, but you can only see that after reloading the page. I think, there was more to fix also when the session ends, so that the form field to fill in returns? Buuut we currently need a reload of the whole page for that anyway. 😢 The React is also of course missing the modal inbetween the first click and ending the session and doesn't look like it should (link). (@khamui @phillimorland )