Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7008]apps/budgeting/vote-button: only show vote button if has sessio… #4885

Merged
merged 2 commits into from
Feb 3, 2023
Merged

[7008]apps/budgeting/vote-button: only show vote button if has sessio… #4885

merged 2 commits into from
Feb 3, 2023

Conversation

khamui
Copy link
Contributor

@khamui khamui commented Jan 30, 2023

…n token and in right phase (list item and detail)

@khamui khamui requested review from goapunk, philli-m and Rineee January 30, 2023 16:31
@philli-m philli-m added the Status: On hold issue or PR paused label Feb 1, 2023
@philli-m
Copy link
Contributor

philli-m commented Feb 1, 2023

@khamui this overlaps with @Rineee permissions PR so will just place this on hold for now until that one has been cleared up

@Rineee Rineee force-pushed the kt-2023-01-hide-votebutton branch 4 times, most recently from b218e4e to e613bc6 Compare February 2, 2023 18:14
Rineee
Rineee approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@Rineee Rineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, cool, you did it the right way! I just changed some naming to match better with what I did, but the rest was fine

@Rineee
Copy link
Contributor

Rineee commented Feb 2, 2023

Setting this to WIP as #4901 should be merged first and then the getting of voting token should be adjusted.

@Rineee Rineee force-pushed the kt-2023-01-hide-votebutton branch from e613bc6 to a54ee0d Compare February 2, 2023 18:33
@Rineee Rineee changed the title [7008]apps/budgeting/vote-button: only show vote button if has sessio… WIP [7008]apps/budgeting/vote-button: only show vote button if has sessio… Feb 2, 2023
@Rineee Rineee force-pushed the kt-2023-01-hide-votebutton branch from a54ee0d to ce3a366 Compare February 3, 2023 09:50
@Rineee Rineee changed the title WIP [7008]apps/budgeting/vote-button: only show vote button if has sessio… [7008]apps/budgeting/vote-button: only show vote button if has sessio… Feb 3, 2023
@Rineee Rineee removed the Status: On hold issue or PR paused label Feb 3, 2023
@Rineee
Copy link
Contributor

Rineee commented Feb 3, 2023

@phillimorland This should be ready now!

philli-m
philli-m approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! :)

@philli-m philli-m merged commit e4d7021 into main Feb 3, 2023
@philli-m philli-m deleted the kt-2023-01-hide-votebutton branch February 3, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rineee Rineee Rineee approved these changes

@philli-m philli-m philli-m approved these changes

@goapunk goapunk Awaiting requested review from goapunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khamui @philli-m @Rineee