Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/cms: use model fields for storefront counts #4940

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

fuzzylogic2000
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 commented Feb 9, 2023

fixes #4358

still missing:

  • management command to use as hourly cron job

@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2023-02-item-count-landing-page branch from b20189f to 2151bd6 Compare February 10, 2023 07:54
@fuzzylogic2000 fuzzylogic2000 changed the title WIP: apps/cms: use model fields for storefront counts apps/cms: use model fields for storefront counts Feb 10, 2023
@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2023-02-item-count-landing-page branch from 6a04276 to 08fe0a0 Compare February 10, 2023 13:41
@fuzzylogic2000 fuzzylogic2000 force-pushed the kl-2023-02-item-count-landing-page branch from d81bf0e to 55e644a Compare February 10, 2023 13:58
Copy link
Contributor

@Rineee Rineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, cool!

@Rineee Rineee merged commit 1144440 into main Feb 10, 2023
@Rineee Rineee deleted the kl-2023-02-item-count-landing-page branch February 10, 2023 15:20
@Rineee
Copy link
Contributor

Rineee commented Feb 10, 2023

After deploying on dev (and running the management command), the order of the tiles changed from

image

to this

image

Does this mean anything @fuzzylogic2000 ?

@fuzzylogic2000
Copy link
Contributor Author

@Rineee That is fine as we choose random tiles for the three tiles: you can add up to six (I think), and we show three random ones in random order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reevaluate how we load the data on the ladning page
2 participants