Jd 2023 02 codes delete background task

[goapunk]

• delete codes in background tasks
• fix some tests
• update translations

[goapunk]

maybe fixes #4963

[Rineee]

Lgtm! Although locally it does take the same amount of time for me (sth like 30 sec), but I guess worth trying on dev.
Do you also want to have a look @fuzzylogic2000 ?

[goapunk]

Lgtm! Although locally it does take the same amount of time for me (sth like 30 sec), but I guess worth trying on dev. Do you also want to have a look @fuzzylogic2000 ?

Maybe we first deploy this branch and test it?

[Rineee]

Lgtm! Although locally it does take the same amount of time for me (sth like 30 sec), but I guess worth trying on dev. Do you also want to have a look @fuzzylogic2000 ?

Maybe we first deploy this branch and test it?

Good idea, yes!

[fuzzylogic2000]

My thought when setting out to do this the first time was to have an extra package model instead of the number. That way when the package is downloaded, we only need to update that in the package model and can delete the plain tokens whenever it happens.
But let's try if this works first! When the actual downloading is the problem, that also won't help.

[fuzzylogic2000]

Is this ready to be reviewed?
And do we still need the package number here or is a package enough?

[goapunk]

Is this ready to be reviewed? And do we still need the package number here or is a package enough?

This is ready now I think. I'm not sure what you mean with the package_numbers?

[fuzzylogic2000]

The code looks good, but I haven't tried it out yet.
I still don't get why we need the package number and can not just use the package without the number. But I will have another look tomorrow morning with a fresh brain.
Maybe @Rineee can also check it out?

[goapunk]

@Rineee @fuzzylogic2000 this is ready for another round of reviews. But don't merge yet, needs squash and translations

[fuzzylogic2000]

Yeah! It reads well. And it nearly works. But when I make a big batch, the "created" is False and not shown in the download section.

>>> TokenPackage.objects.all()
<QuerySet [<TokenPackage: TokenPackage object (1)>, <TokenPackage: TokenPackage object (2)>, <TokenPackage: TokenPackage object (3)>]>
>>> TokenPackage.objects.all()[0].module
<Module: Bürger*innenhaushalt (3 Phasen) - new bürherhaushalt s (1)>
>>> TokenPackage.objects.all()[1].module
<Module: Bürger*innenhaushalt (3 Phasen) - new bürherhaushalt s (1)>
>>> TokenPackage.objects.all()[2].module
<Module: Bürger*innenhaushalt (3 Phasen) - new bürherhaushalt s (1)>
>>> TokenPackage.objects.all()[0].size
10
>>> TokenPackage.objects.all()[1].size
1000000
>>> TokenPackage.objects.all()[2].size
200
>>> TokenPackage.objects.all()[0].created()
True
>>> TokenPackage.objects.all()[1].created()
False
>>> TokenPackage.objects.all()[2].created()
False

[fuzzylogic2000]

Yeah! It reads well. And it nearly works. But when I make a big batch, the "created" is False and not shown in the download section.

Ah! I didn't wait long enough and forgot about the batch size of 100.000. So, it was simply that not all tasks were run yet. 🤦 It works perfectly fine!

[goapunk]

@fuzzylogic2000 @Rineee rebased and added the translations, is ready to be merged now

[Rineee]

The admin part does not really work, it throws an error when creating a token and also when changing a token, it adds 1 to the package size..

Also it did not show any packages in the dashboard, but that is most likely a me problem, I will check again tomorrow with fresh brain!

[Rineee]

I managed again to produce an error 🙈 I had a package in which all codes were inactive and downloading that throws an error.. I dont know if that is too much of an edge case, but probably we should fix that anyway? Or what do you think @fuzzylogic2000 ?

Apart from that it works perfectly and from my side good to merge!

[fuzzylogic2000]

Nice! I think it is a good solution with the packages and the size and so on!
Maybe we can also add the packages to the django-admin, so that they can be deleted if need be. But not in this PR anymore! :)

[fuzzylogic2000]

I managed again to produce an error see_no_evil I had a package in which all codes were inactive and downloading that throws an error.. I dont know if that is too much of an edge case, but probably we should fix that anyway? Or what do you think @fuzzylogic2000 ?

Apart from that it works perfectly and from my side good to merge!

@Rineee Yeeees, I didn't try that, but will also do that. We should probably fix that even though it is an edge case.

[Rineee]

I managed again to produce an error see_no_evil I had a package in which all codes were inactive and downloading that throws an error.. I dont know if that is too much of an edge case, but probably we should fix that anyway? Or what do you think @fuzzylogic2000 ?
Apart from that it works perfectly and from my side good to merge!

@Rineee Yeeees, I didn't try that, but will also do that. We should probably fix that even though it is an edge case.

@goapunk actually thought of it and raises the bad request here: https://github.com/liqd/a4-meinberlin/pull/4965/files#diff-ef2af1f23503a2f006e8048ad40751390211bb74ca18c6882369e290b66f022bR67
But I guess we should probably not show packages that have only inactive tokens?

[fuzzylogic2000]

I managed again to produce an error see_no_evil I had a package in which all codes were inactive and downloading that throws an error.. I dont know if that is too much of an edge case, but probably we should fix that anyway? Or what do you think @fuzzylogic2000 ?
Apart from that it works perfectly and from my side good to merge!

@Rineee Yeeees, I didn't try that, but will also do that. We should probably fix that even though it is an edge case.

@goapunk actually thought of it and raises the bad request here: https://github.com/liqd/a4-meinberlin/pull/4965/files#diff-ef2af1f23503a2f006e8048ad40751390211bb74ca18c6882369e290b66f022bR67 But I guess we should probably not show packages that have only inactive tokens?

@goapunk @Rineee I agree. Let's fix that by not showing these packages. I will merge anyway and hope that noone tests that. :p

Traceback (most recent call last):
  File "/home/katharina/a4-meinberlin/venv/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/katharina/a4-meinberlin/venv/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/katharina/a4-meinberlin/venv/lib/python3.10/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/katharina/a4-meinberlin/venv/lib/python3.10/site-packages/django/contrib/auth/mixins.py", line 104, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/home/katharina/a4-meinberlin/venv/lib/python3.10/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/home/katharina/a4-meinberlin/venv/lib/python3.10/site-packages/adhocracy4/exports/views.py", line 38, in get
    for rownum, row in enumerate(self.export_rows(), start=1):
  File "/home/katharina/a4-meinberlin/meinberlin/apps/votes/exports.py", line 68, in export_rows
    raise BadRequest

Exception Type: BadRequest at /dashboard/modules/burgerinnenhaushalt-3-phasen-3/download-codes/export/
Exception Value: