WIP: add mypy as static type checker #5678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2024-07-mypy-type-checker
branch
3 times, most recently
from
c165413 to
ba43c52
Compare
goapunk
force-pushed
the
jd-2024-07-mypy-type-checker
branch
from
ba43c52 to
7887b38
Compare
|
@m4ra I was playing around with this a while ago when I realized I had added a wrong type hint and thought having a check for it would be nice, but it also means we have to add type hints a lot, so I'm not really sure if it's worth it. What do you think? |
|
I am up for it. However this workflow needs 18 fixes for the tests to pass /: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Briefly explain what you did and provide context for a clearer understanding.
Tasks