[#8767] notifications: add fine-grained notification settings per user #6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hom3mad3
reviewed
Feb 11, 2025
| .map((n) => Object.keys(n.notifications).some((key) => notificationsState[key])) | ||
| }, [notificationsState, showRestricted]) | ||
|
|
||
| return [ |
There was a problem hiding this comment.
wonder if returning an object here would make life easier
hom3mad3
approved these changes
Feb 11, 2025
|
@vellip since this is quite django heavy, i'll leave it for someone else to review and merge @goapunk @m4ra @partizipation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This change adds the backend for more fine-grained notification settings. They are separated into:
notifyfields, which are meant for email notifications, andtrackfields, which are meant for activity-feed type (in-app) notificationsTo not overflow the
Usermodel with a multitude of boolean fields aOneToOneFieldwas used, pointing toUser. It will be generated via signal, and if it does not exist still, on signup.This PR also updates the frontend to allow for saving these values into the database and a cleaner frontend code.
Tasks