Kl 2022 04 newsletter project #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzylogic2000
force-pushed
the
kl-2022-04-newsletter-project
branch
from
75b1233 to
15e4af1
Compare
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 246e562 |
fuzzylogic2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds newsletter tests
second commit is a4-depending (needs to be updated after tests/factories: move FollowFactory to be used in projects adhocracy4#1057 is merged) -> done and fine!
but what I set of to do, which is fixing this sending newsletter from empty organisations throws 500 #1737 is still missing
My explanation about why it did not work was all wrong. Bit now it does work and fixes the issue!