This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Switch from compass to node-sass #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 5, 2016 19:16
@include inline-block also sets vertical align. This is not always required. Some other places could also be affected, but this commit coveres most of it.
has many useful features - math - color contrast - advanced color functions - grid
we have sourcemaps for development
|
yeah, less ruby more node |
Conflicts: src/adhocracy_frontend/adhocracy_frontend/static/stylesheets/scss/components/_type.scss
|
See c498d79: |
This was referenced Jul 6, 2016
Merged
xi
pushed a commit
that referenced
this pull request
Aug 17, 2016
regression was introduced in #2482
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the dependency on compass, sass, and susy and instead adds dependecy on grunt-sass, node-sass, and sass-planifolia. The resons for that are:
Note that sass-planifolia is not a popular library. It is in fact maintained by myself. I think that is fine though as a large part of it is based on the contrast code from a3. So you could think of planifolia as a library that originated from a3 and is now maintained separately.