Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

categories//labels/models: add default ordering #1272

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Nov 22, 2022

This should fix liqd/a4-meinberlin#4654, I will also add it for the moderation tasks in mB then.

Apparently there is no default ordering, I checked the broken example that was linked in the issue and indeed the categories were in random order there, although in most cases it works? Since we do not have a created field here, I guess pk is the best bet!

@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.22% 105/1139
🔴 Branches 10.97% 77/702
🔴 Functions 9.54% 35/367
🔴 Lines 15.66% 548/3500

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from d4b60a6

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@fuzzylogic2000 fuzzylogic2000 merged commit 69a49a9 into main Nov 23, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2022-11-category-ordering branch November 23, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order of categories should be same in dashboard and user front end
2 participants