Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve GatewayServer declerative setup in 1.0 #2732

Closed
EladDolev opened this issue Sep 16, 2024 · 1 comment
Closed

[Feature] Improve GatewayServer declerative setup in 1.0 #2732

EladDolev opened this issue Sep 16, 2024 · 1 comment

Comments

@EladDolev
Copy link
Contributor

Is your feature request related to a problem? Please describe.

With current implementation, creating the GatewayServer resource would generate a Secret resource with a key pair unless a secret already exists.
That makes it very hard for declarative setup that uses SealedSecret for example for creating this Secret as the sealed-secrets controller would refuse to touch the Secret if it already exists, hence there's a race condition here

Describe the solution you'd like

A way of preventing automatically creating the Secret resource with a key pair when creating the GatewayServer resource

Describe alternatives you've considered

I have no alternatives other than manual intervention or manual setup which kinda beats the purpose of declarative setup

@fra98 fra98 pinned this issue Oct 7, 2024
@fra98 fra98 unpinned this issue Oct 7, 2024
@claudiolor
Copy link
Contributor

Fixed with #2747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants