Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Gateway external secrets #2747

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Sep 30, 2024

Description

This pr makes it possible to specify an existing secret or a secret that will exist for wireguard keys

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

13 similar comments
@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Sep 30, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 1, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 2, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 2, 2024

/build

@aleoli aleoli force-pushed the aol/gw-ext-secrets branch 2 times, most recently from 68dbc40 to 4e41df9 Compare October 2, 2024 09:45
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Oct 2, 2024
@aleoli aleoli force-pushed the aol/gw-ext-secrets branch from 4e41df9 to a3e0804 Compare October 2, 2024 09:51
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Oct 2, 2024
@aleoli
Copy link
Member Author

aleoli commented Oct 2, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Oct 2, 2024

/rebase test=true

@aleoli aleoli marked this pull request as ready for review October 2, 2024 14:09
@fra98
Copy link
Member

fra98 commented Oct 7, 2024

Fix #2732

@aleoli aleoli force-pushed the aol/gw-ext-secrets branch from 92d4959 to 38d11ad Compare October 11, 2024 08:11
@claudiolor
Copy link
Contributor

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 17, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Oct 17, 2024

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Oct 17, 2024
@aleoli aleoli force-pushed the aol/gw-ext-secrets branch from c44a594 to 8a20e26 Compare October 18, 2024 08:38
@aleoli
Copy link
Member Author

aleoli commented Oct 18, 2024

/unhold

@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Oct 18, 2024
@aleoli
Copy link
Member Author

aleoli commented Oct 18, 2024

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Oct 18, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 18, 2024
@adamjensenbot adamjensenbot merged commit 6bb96dd into liqotech:master Oct 18, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants