AKS Private Link #1985
Merged
AKS Private Link #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @scottboring. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
Sharathmk99
reviewed
Sep 6, 2023
aleoli
reviewed
Sep 8, 2023
There was a problem hiding this comment.
Hi, @scottboring! The PR looks good to me. Can you please fix this comment? And then I think we can merge.
|
@aleoli thank you for reviewing. The requested change has been made. |
aleoli
approved these changes
Sep 11, 2023
|
/rebase test=true |
adamjensenbot
force-pushed
the
aks-private-endpoint
branch
from
41e7313 to
ebe3f7d
Compare
frisso
reviewed
Sep 11, 2023
scottboring
force-pushed
the
aks-private-endpoint
branch
from
ebe3f7d to
c831012
Compare
|
@aleoli commits have been squashed |
|
/rebase test=true |
adamjensenbot
force-pushed
the
aks-private-endpoint
branch
from
c831012 to
fcd9e38
Compare
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding privateLink flag to liqoctl to better support private AKS clusters. AKS clusters that use private link have a generated fqdn stored on the AKS cluster object as privateFQDN in addition to a public FQDN which is likely blocked through Azure policies.
Fixes #(issue)
This has been tested locally to verify the correct fqdn property is used based on flag presence or absence.