Liqo Gateway & Auth Service Loadbalancer Static IP #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sharathmk99. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
frisso
reviewed
Sep 13, 2023
frisso
reviewed
Sep 13, 2023
Sharathmk99
force-pushed
the
gateway-service-loadbalancer-static-ip
branch
from
39abce7 to
2e9a14d
Compare
Sharathmk99
changed the title
Sharathmk99
force-pushed
the
gateway-service-loadbalancer-static-ip
branch
from
2e9a14d to
5fb179d
Compare
|
Ready for review. Thanks. |
Sharathmk99
force-pushed
the
gateway-service-loadbalancer-static-ip
branch
from
5fb179d to
a13c0b4
Compare
frisso
reviewed
Sep 14, 2023
frisso
reviewed
Sep 17, 2023
frisso
reviewed
Sep 17, 2023
frisso
reviewed
Sep 17, 2023
frisso
reviewed
Sep 17, 2023
frisso
approved these changes
Sep 17, 2023
|
@Sharathmk99 This looks good to me. Just commit my suggestions, if you agree, and we're all set. |
Sharathmk99
force-pushed
the
gateway-service-loadbalancer-static-ip
branch
from
3b67a88 to
50d14ac
Compare
frisso
approved these changes
Sep 18, 2023
Sharathmk99
force-pushed
the
gateway-service-loadbalancer-static-ip
branch
from
50d14ac to
c17b7ea
Compare
|
/rebase test=true |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
When exposing Liqo Gateway & Auth service as
LoadBalancercurrently it's only possible to change thetypetoLoadBalancer, but in some cloud provided we are able to create Static LoadBalancer and use IP inloadBalancerIPfield. This PR will allow user to set custom LoadBalancer IP.Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.