liqo-route: mac annotation fix #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
Thank you so much for this fix. Will build and test it out in our cluster. |
aleoli
approved these changes
Sep 13, 2023
frisso
reviewed
Sep 13, 2023
|
/rebase test=true |
adamjensenbot
force-pushed
the
master
branch
from
e5459e1 to
5ec03e6
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
master
branch
from
5ec03e6 to
a3fe4e9
Compare
|
/rebase test=true |
|
/rebase test=true |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the method used to understand if a reconciled pod is the pod where the controller is running.
Previously we checked that the reconciled pod IP and the pod where the IP is running have the same IP. In some rare cases, this creates problems, in fact, if a node is deleted and another node is created with the same IP, it's possible that the controller gets an event that refer to a zombie pod.
Using the podName instead of the IP solves this problem.