Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing ClusterRole to liqo-webhook #2726

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

EladDolev
Copy link
Contributor

Description

When running more than one replicas of the liqo-webhook nothing is working without those permissions here
They may be too much, and there may be other permissions missing in other places, I only know I managed to get things working by adding those

@adamjensenbot
Copy link
Collaborator

Hi @EladDolev. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the kind/bug Something isn't working label Sep 10, 2024
@aleoli
Copy link
Member

aleoli commented Oct 4, 2024

Hi @EladDolev!

Thanks for your pr. This file is auto-generated; I'm adding a commit to your pr to change it in the correct position because it's easier to show you than explain what you have to do 😅

Feel free to squash this commit into your

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 4, 2024
@EladDolev
Copy link
Contributor Author

Thank you Alessandro
I'm happy to skip the squash and merge as-is

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 7, 2024
@aleoli
Copy link
Member

aleoli commented Oct 7, 2024

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Oct 7, 2024

Ok, perfect. Can you please rebase your pr and resolve the conflict? I don't have permission to force push on your branch

Signed-off-by: Elad Dolev <dolevelad@gmail.com>
@EladDolev
Copy link
Contributor Author

PR is ready @aleoli, thank you !

@fra98
Copy link
Member

fra98 commented Oct 8, 2024

/test

@aleoli aleoli merged commit 9143179 into liqotech:master Oct 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants