-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing ClusterRole to liqo-webhook #2726
Conversation
Hi @EladDolev. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
Hi @EladDolev! Thanks for your pr. This file is auto-generated; I'm adding a commit to your pr to change it in the correct position because it's easier to show you than explain what you have to do 😅 Feel free to squash this commit into your |
Thank you Alessandro |
/rebase test=true |
Ok, perfect. Can you please rebase your pr and resolve the conflict? I don't have permission to force push on your branch |
Signed-off-by: Elad Dolev <dolevelad@gmail.com>
a9f3ead
to
a02725c
Compare
PR is ready @aleoli, thank you ! |
/test |
Description
When running more than one replicas of the liqo-webhook nothing is working without those permissions here
They may be too much, and there may be other permissions missing in other places, I only know I managed to get things working by adding those