Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller-runtime from 0.18.5 to 0.19.0 #2751

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Bump controller-runtime from 0.18.5 to 0.19.0 #2751

merged 3 commits into from
Oct 4, 2024

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Oct 2, 2024

Description

Bumps sigs.k8s.io/controller-runtime from 0.18.5 to 0.19.0.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

cheina97 commented Oct 2, 2024

/build

@cheina97 cheina97 marked this pull request as draft October 2, 2024 17:08
@cheina97
Copy link
Member Author

cheina97 commented Oct 2, 2024 •
edited
Loading

This PR needs virtual-kubelet/virtual-kubelet#1247 to be merged

At the moment it is using a fork

@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from 2142db1 to 10eb5c7 Compare October 2, 2024 17:32
@cheina97 cheina97 marked this pull request as ready for review October 2, 2024 17:33
@cheina97
Copy link
Member Author

cheina97 commented Oct 2, 2024

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Oct 2, 2024
@cheina97
Copy link
Member Author

cheina97 commented Oct 2, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frc/bumpControllerRuntime branch from 10eb5c7 to 0623228 Compare October 2, 2024 17:36
@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from 0623228 to 0518a5f Compare October 2, 2024 17:54
@cheina97
Copy link
Member Author

cheina97 commented Oct 2, 2024

/rebase test=true

@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from a38d6bb to cad6d20 Compare October 2, 2024 19:02
@cheina97
Copy link
Member Author

cheina97 commented Oct 2, 2024

/rebase test=true

@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from cad6d20 to 101932c Compare October 3, 2024 10:02
@cheina97
Copy link
Member Author

cheina97 commented Oct 3, 2024

/rebase test=true

@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from 101932c to ff2871c Compare October 4, 2024 09:33
@cheina97
Copy link
Member Author

cheina97 commented Oct 4, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frc/bumpControllerRuntime branch from ff2871c to a645d57 Compare October 4, 2024 09:37
@cheina97
Copy link
Member Author

cheina97 commented Oct 4, 2024

/rebase test=true

@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch 6 times, most recently from 02d5076 to 6d15db4 Compare October 4, 2024 15:31
@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from 6d15db4 to df5f5f7 Compare October 4, 2024 15:37
@cheina97 cheina97 force-pushed the frc/bumpControllerRuntime branch from df5f5f7 to b9844ac Compare October 4, 2024 15:39
@cheina97
Copy link
Member Author

cheina97 commented Oct 4, 2024

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Oct 4, 2024

/merge

@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels Oct 4, 2024
@cheina97
Copy link
Member Author

cheina97 commented Oct 4, 2024

/unhold

@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Oct 4, 2024
@cheina97
Copy link
Member Author

cheina97 commented Oct 4, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 4, 2024
@adamjensenbot adamjensenbot merged commit 3553997 into liqotech:master Oct 4, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 4, 2024
@cheina97 cheina97 deleted the frc/bumpControllerRuntime branch October 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli