Assign unique names to all controllers #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
fra98
changed the title
fra98
force-pushed
the
frt/naming-controllers
branch
2 times, most recently
from
9c5775b to
d140a49
Compare
fra98
force-pushed
the
frt/naming-controllers
branch
from
2ccae2c to
72320c1
Compare
|
/build |
claudiolor
reviewed
Oct 14, 2024
fra98
force-pushed
the
frt/naming-controllers
branch
from
72320c1 to
97a682d
Compare
claudiolor
approved these changes
Oct 14, 2024
|
/build |
|
/test |
cheina97
approved these changes
Oct 14, 2024
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unique name to all Liqo controllers.
This has been mandatory since controller-runtime v0.19.0, as assigning the same name to multiple controllers on the same container causes the pod to panic.
Ultimately, this will improve logging, making it easier to identify which controller produced a specific log.