Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retrieve publickey resources by labels #2773

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: retrieve publickey resources by labels #2773

merged 1 commit into from
Oct 18, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Oct 9, 2024

Description

This PR fixes a bug in Liqoctl where PublicKey resources were retrieved by name instead of labels.

@fra98 fra98 added the kind/bug label Oct 9, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/get-pk-by-labels branch 2 times, most recently from 841ac70 to 7d6d1d6 Compare October 14, 2024 15:51
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 14, 2024
@fra98 fra98 marked this pull request as ready for review October 14, 2024 15:52
@fra98 fra98 requested review from aleoli and cheina97 October 14, 2024 15:52
claudiolor
claudiolor approved these changes Oct 16, 2024
View reviewed changes
pkg/liqoctl/network/cluster.go Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/get-pk-by-labels branch from 7d6d1d6 to c5b9c9c Compare October 18, 2024 08:49
@fra98 fra98 force-pushed the frt/get-pk-by-labels branch from c5b9c9c to b820bfe Compare October 18, 2024 10:00
@fra98
Copy link
Member Author

fra98 commented Oct 18, 2024

/test

@fra98
Copy link
Member Author

fra98 commented Oct 18, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 18, 2024
@adamjensenbot adamjensenbot merged commit 9036cdb into liqotech:master Oct 18, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@claudiolor claudiolor claudiolor approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fra98 @adamjensenbot @claudiolor @aleoli