[Feat] liqoctl gateway template check #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/templatecheck
branch
from
51ea3b0 to
675d0dd
Compare
cheina97
changed the title
cheina97
requested review from
claudiolor,
aleoli and
fra98
and removed request for
claudiolor,
aleoli and
fra98
cheina97
force-pushed
the
frc/templatecheck
branch
from
675d0dd to
1f68d98
Compare
aleoli
reviewed
Oct 28, 2024
deployments/liqo/templates/liqo-wireguard-gateway-server-template.yaml
Outdated
Show resolved
Hide resolved
claudiolor
reviewed
Oct 28, 2024
cheina97
force-pushed
the
frc/templatecheck
branch
2 times, most recently
from
80705e9 to
64e9f00
Compare
fra98
reviewed
Oct 30, 2024
cheina97
force-pushed
the
frc/templatecheck
branch
from
64e9f00 to
305aafe
Compare
fra98
approved these changes
Oct 30, 2024
cheina97
force-pushed
the
frc/templatecheck
branch
2 times, most recently
from
669f1b8 to
eed1239
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frc/templatecheck
branch
from
eed1239 to
7c5d3ee
Compare
|
/rebase test=true |
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some checks in liqoctl (at peering time) about the gateway template used.
This checks are:
--server-service-nodeportflag has been specified, it checks if the template selected support static nodeports--server-service-loadbalanceripflag has been specified, it checks if the template selected support static load balancer ips