-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wggateway controllers pod watch #2815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/testnet
branch
from
November 14, 2024 11:11
6001767
to
7c99a03
Compare
/rebase test=true |
cheina97
force-pushed
the
frc/testnet
branch
from
November 14, 2024 12:35
7c99a03
to
82441e5
Compare
fra98
approved these changes
Nov 14, 2024
fra98
approved these changes
Nov 14, 2024
cheina97
force-pushed
the
frc/testnet
branch
from
November 14, 2024 14:04
82441e5
to
430a7fd
Compare
/rebase test=true |
-merge |
/merge |
adamjensenbot
added
the
merge-requested
Request bot merging (automatically managed)
label
Nov 14, 2024
adamjensenbot
removed
the
merge-requested
Request bot merging (automatically managed)
label
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug about wireguard gateway server and client controllers. With the new leader election mechanism introduced to support HA on gateways these controllers need to be triggered when gateway pod labels change.