Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm] uniform flag names #2855

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[Helm] uniform flag names #2855

merged 1 commit into from
Dec 12, 2024

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Dec 9, 2024 •
edited
Loading

Description

This pr uniforms flag names (enable/enabled in particular) in the Liqo Helm chart

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Dec 9, 2024

/test

@aleoli aleoli marked this pull request as ready for review December 9, 2024 15:21
@aleoli aleoli force-pushed the aol/helm-flag-uniform branch from 2c1d101 to 782cdfd Compare December 10, 2024 08:59
@aleoli
Copy link
Member Author

aleoli commented Dec 10, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Dec 12, 2024

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Dec 12, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 12, 2024
@adamjensenbot adamjensenbot merged commit a5f2198 into liqotech:master Dec 12, 2024
13 checks passed
@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@claudiolor claudiolor claudiolor approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleoli @adamjensenbot @claudiolor @fra98