sonarr: add support for snowflake and db2 (DAT-17397) #199
Conversation
|
Should I be incrementing the version on this PR? |
is the change for this tested ? |
No. Not sure how to test it, to be honest. But since it follows the existing pattern with the other databases, I thought it seemed logical. Here's the PRs where it will be implemented (but of course, these PRs depend on this being merged first): https://github.com/liquibase/liquibase-pro/pull/1670 |
you can do something like this to test if it works and so that we can upgrade the build-logic tag later ones we know it's tested and works: |
|
Hey @StevenMassaro Some changes need to be made in |
|
@sayaliM0412 I tested this code here: https://github.com/liquibase/liquibase/actions/runs/8806319321/job/24171805932 @jandroav I made those changes to Liquibase here: liquibase/liquibase#5837 Though I added Snowflake support in this PR, we're not actually ready to use it in OSS or Pro yet. I did log https://datical.atlassian.net/browse/DAT-17537 to fix that. |
StevenMassaro
changed the title
….7.3 build(extension-attach-artifact-release.yml): update liquibase/build-logic version to v0.7.3 build(extension-release-prepare.yml): update liquibase/build-logic version to v0.7.3 build(extension-release-published.yml): update liquibase/build-logic version to v0.7.3 build(fossa_ai.yml): update liquibase/build-logic version to v0.7.3 build(os-extension-test.yml): update liquibase/build-logic version to v0.7.3 build(pom-release-published.yml): update liquibase/build-logic version to v0.7.3 build(pro-extension-test.yml): update liquibase/build-logic version to v0.7.3 docs(README.md): update build-logic version to v0.7.3 in documentation
|
Nice @StevenMassaro, please change I am updating versions in this PR: 16ba11f |
|
Thanks @jandroav ! @jnewton03 or @sayaliM0412 , could we get a review and a merge on this story? |
No description provided.