Update Dockerfile to use Temurin Java #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenJDK has been deprecated: https://hub.docker.com/_/openjdk DEPRECATION NOTICE This image is officially deprecated and all users are recommended to find and use suitable replacements ASAP. Some examples of other Official Image alternatives (listed in alphabetical order with no intentional or implied preference): amazoncorretto eclipse-temurin ibm-semeru-runtimes ibmjava sapmachine See docker-library/openjdk#505 for more information. The only tags which will continue to receive updates beyond July 2022 will be Early Access builds (which are sourced from jdk.java.net), as those are not published/supported by any of the above projects.
|
I tested this build locally and it built successfully, though the size goes from 373MB to 395MB. |
|
@r2liquibase Wasn't there a specific reason we chose the |
|
@mcred we chose OpenJDK because we were trying to get into the Docker verified program. Since we're pushing on that, there is no reason to use it. Use whatever the team thinks is best. |
mcred
approved these changes
Jul 19, 2022
ap-liquibase
approved these changes
Jul 19, 2022
nvoxland
approved these changes
Jul 19, 2022
|
using 17 passed locally. Re-requesting review. |
mcred
approved these changes
Jul 19, 2022
|
this has the problem of introducing curl which is littered with CVEs |
|
@tooptoop4 Will you link to a specific CVE that was introduced with this PR? |
|
@tooptoop4 which CVE from that list was introduced with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenJDK has been deprecated:
https://hub.docker.com/_/openjdk
DEPRECATION NOTICE
This image is officially deprecated and all users are recommended to find and use suitable replacements ASAP. Some examples of other Official Image alternatives (listed in alphabetical order with no intentional or implied preference):
amazoncorretto
eclipse-temurin
ibm-semeru-runtimes
ibmjava
sapmachine
See docker-library/openjdk#505 for more information.
The only tags which will continue to receive updates beyond July 2022 will be Early Access builds (which are sourced from jdk.java.net), as those are not published/supported by any of the above projects.