Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT-18816: add support for different PRO extensions in Dockerfile #89

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

sayaliM0412
Copy link
Contributor

feat: Dockerfile: add support for different PRO extensions in Dockerfile. Ran it locally to check what packages and versions are getting added: liquibase-aws-license-service@v1.0.2 has extension as Category. Do we want it to be pro instead?

cc: @suryaaki2 @abrackx @filipelautert

Screenshot 2024-10-10 at 11 57 20 AM

@suryaaki2
Copy link
Contributor

feat: Dockerfile: add support for different PRO extensions in Dockerfile. Ran it locally to check what packages and versions are getting added: liquibase-aws-license-service@v1.0.2 has extension as Category. Do we want it to be pro instead?

cc: @suryaaki2 @abrackx @filipelautert

Screenshot 2024-10-10 at 11 57 20 AM

That shouldn't matter

@suryaaki2
Copy link
Contributor

feat: Dockerfile: add support for different PRO extensions in Dockerfile. Ran it locally to check what packages and versions are getting added: liquibase-aws-license-service@v1.0.2 has extension as Category. Do we want it to be pro instead?
cc: @suryaaki2 @abrackx @filipelautert
Screenshot 2024-10-10 at 11 57 20 AM

That shouldn't matter

What license-checks? we are not adding?

Dockerfile Outdated
Comment on lines 9 to 10
lpm add liquibase-aws-license-service liquibase-s3-extension liquibase-aws-secrets-manager \
liquibase-commercial-mongodb liquibase-commercial-dynamodb liquibase-checks --global
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lpm add liquibase-aws-license-service liquibase-s3-extension liquibase-aws-secrets-manager \
liquibase-commercial-mongodb liquibase-commercial-dynamodb liquibase-checks --global
lpm add \
liquibase-aws-license-service \
liquibase-s3-extension \
liquibase-aws-secrets-manager \
liquibase-commercial-mongodb \
liquibase-commercial-dynamodb \
liquibase-checks \
--global

@sayaliM0412
Copy link
Contributor Author

sayaliM0412 commented Oct 10, 2024

feat: Dockerfile: add support for different PRO extensions in Dockerfile. Ran it locally to check what packages and versions are getting added: liquibase-aws-license-service@v1.0.2 has extension as Category. Do we want it to be pro instead?
cc: @suryaaki2 @abrackx @filipelautert
Screenshot 2024-10-10 at 11 57 20 AM

That shouldn't matter

What license-checks? we are not adding?

  • after running the command lpm ls -g, we see all of them :

  • Screenshot 2024-10-10 at 1 50 41 PM

  • Screenshot 2024-10-10 at 1 51 33 PM

Copy link

sonarcloud bot commented Oct 10, 2024

@sayaliM0412 sayaliM0412 merged commit 864cbeb into main Oct 10, 2024
15 checks passed
@sayaliM0412 sayaliM0412 deleted the DAT-18816 branch October 10, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants