✨ update AWS MP listing automation #94
Open
+101
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2024 16:53
…pendabot PRs for Dockerfile Changes
…f tag already exists
StevenMassaro
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
I noticed this as well: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#enable-auto-merge-on-a-pull-request
not sure if it's any easier than what you have here though.
Comment on lines
97
to
105
| - name: Submit New Version Request for AWS MP Listing | ||
| env: | ||
| ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }} | ||
| IMAGE_TAG: ${{ github.event.inputs.image_tag }} | ||
| PRODUCT_ID: ${{ secrets.PRODUCT_ID }} | ||
| AWS_MP_REGISTRY: ${{ secrets.AWS_MP_REGISTRY }} | ||
| run: | | ||
| chmod +x ./.github/utils/submit-aws-mp-listing.sh | ||
| ./.github/utils/submit-aws-mp-listing.sh |
There was a problem hiding this comment.
Do we actually want to submit a new version request during dry run?
There was a problem hiding this comment.
yes, we do but under a dry run it would be a "private" listing and not public. That way QA can test it. Before we release the actual one under OSS version eg : 4.29.2
filipelautert
approved these changes
Oct 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
.github/workflows/dependabot-pr-merge-docker-changes.yml: Auto Merge Dependabot PRs for Dockerfile Changesfeat:
.github/workflows/deploy-extension-to-marketplace.yml: removeworkflow_dispatchand adddry-runcapability to deploy extension to Marketplace to testfix:
README.md: update readme