Fix for #143: Let the driver determine the dataset location if non given #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Simba driver documentation, the location is automatically handled based on where the dataset exists.
filipelautert
requested changes
May 1, 2024
| @@ -20,7 +20,7 @@ | |||
| */ | |||
|
|
|||
| public class BigqueryConnection extends JdbcConnection { | |||
| private String location = "US"; | |||
| private String location = ""; | |||
There was a problem hiding this comment.
You can remove this local variable too.
filipelautert
requested changes
May 1, 2024
…condition for the open function.
filipelautert
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Google Simba driver documentation, the driver will automatically determine the dataset location.
This PR leaves the ability to set the location via the JDBC URL, but removes the else statement setting the default to be the US.